Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate more implicit optional #1858

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Eliminate more implicit optional #1858

merged 1 commit into from
Oct 27, 2023

Conversation

alexrudd2
Copy link
Collaborator

41 -> 19 mypy errors.

Take the simple fixes from #1856

@alexrudd2 alexrudd2 force-pushed the implicit-optional-easy branch from b57b9a2 to 8c8e8df Compare October 26, 2023 22:25
janiversen
janiversen approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@janiversen janiversen merged commit d57922b into dev Oct 27, 2023
1 check passed
@janiversen janiversen deleted the implicit-optional-easy branch October 27, 2023 06:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen